Remove binary modul from Link.modul_to_run #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only its id is needed, and it makes for a clearer and less confusing interface.
zapashcanon
force-pushed
the
no_binary_modul_after_linking
branch
from
2c9d735 to
9fb936a
Compare
|
I rebased. IIRC I had a doubt about the correctness of this (I was afraid of mixing the identifier of a module coming from On the other hand, this does not seem to break anything so I'm merging as it is a simplification. I'm merging, if this was wrong there's still the possibility to revert in the future. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only its id is needed, and it makes for a clearer and less confusing interface.