Create Synchronzier module #360
Conversation
|
Because Ocaml does not possess an optimizing compiler, we should check that this does not tank performances and manually add [@@inline] where needed to try and salvage what demands salvation. |
|
Can you add a |
| type ('get, 'write) t = | ||
| { mutex : Mutex.t | ||
| ; cond : Condition.t | ||
| ; getter : unit -> 'get option |
There was a problem hiding this comment.
The idea is that this is a closure that when called, gets one element to run, without caring for synchronization. Typically, for a Queue, this is fun () -> Queue.take_opt q, and for concolic this will be fun () -> find_node_to_run tree.
krtab
force-pushed
the
synchronizer
branch
2 times, most recently
from
913631d to
94292bf
Compare
|
Once this is effectively used in concollic, I'll add documentation and close #363 |
|
I'm asking for a |
|
Yes, I have added a mli :) |
| match get q true with | ||
| | None -> () | ||
| | Some v -> | ||
| let () = f v (fun v -> write v q) in |
There was a problem hiding this comment.
f v ...; was more idiomatic.
There was a problem hiding this comment.
But didn't constrain the return type to be unit.
|
Thanks! |
No description provided.