clean concolic code #351
Closed
clean concolic code #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zapashcanon
force-pushed
the
cleanconcolic
branch
from
15d3b0c to
ae24c01
Compare
|
@chambart it seems to be looping indefinitely when running the tests, I need to investigate 😅 |
krtab
approved these changes
Jul 10, 2024
| @@ -203,7 +185,8 @@ let rec add_trace pc node (trace : trace) to_update : eval_tree list = | |||
| | Trap Unreachable -> begin | |||
| match node.node with | |||
| | Not_explored -> node.node <- Unreachable | |||
| | Unreachable -> () | |||
| | Unreachable -> | |||
| (* it means we explored two times the same branch ! :S *) assert false | |||
There was a problem hiding this comment.
Suggested change
| (* it means we explored two times the same branch ! :S *) assert false | |
| (* This check is not needed for correctness. If it ends up being too | |
| annoying to satisfy, especially when going multithreaded, we could | |
| remove it *) | |
| failwith "Branch shouldn't have been explored twice" |
There was a problem hiding this comment.
Really ? My understanding is that reaching this point means that we did not marked a node as "explored" properly and it's really something we want to avoid, right?
|
@krtab, I can't merge as the tests are looping indefinitely with this change.. |
|
Closing in favor of #406. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #312 and other things