Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default optimization level to O3 #350

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

zapashcanon
Copy link
Member

No description provided.

@zapashcanon
Copy link
Member Author

cc @filipeom, in test/c/collections-c/pqueue_tests.t we are not detecting the heap overflow with -O3, I don't know these tests so I would say it's a regression but on Test-Comp we're clearly better with -O3 so I'd like to still make it the default, what do you think?

@filipeom
Copy link
Collaborator

filipeom commented Jul 4, 2024

cc @filipeom, in test/c/collections-c/pqueue_tests.t we are not detecting the heap overflow with -O3, I don't know these tests so I would say it's a regression but on Test-Comp we're clearly better with -O3 so I'd like to still make it the default, what do you think?

I think it's ok, it's expected when one compiles with optimizations some memory errors might no longer be detected. For Test-Comp we're not focused on verifying memory safety so I agree that we should make the best parameters the default 😄

@zapashcanon zapashcanon merged commit a286e0a into OCamlPro:main Jul 4, 2024
3 checks passed
@zapashcanon zapashcanon deleted the defaultopt branch July 4, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants