valide binary module in script, promote tests

OCamlPro · Jul 3, 2024 · 93b8a72 · 93b8a72
1 parent d265297
commit 93b8a72
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/script/script.ml b/src/script/script.ml
@@ -188,10 +188,13 @@ let run ~no_exhaustion ~optimize script =
         let+ () =
           match got with
           | Error got -> check_error ~expected ~got
-          | Ok m ->
-            (* TODO: there should be some checks here before linking ! *)
-            let got = Link.modul link_state ~name:None m in
-            check_error_result expected got
+          | Ok m -> begin
+            match Typecheck.modul m with
+            | Error got -> check_error ~expected ~got
+            | Ok () ->
+              let got = Link.modul link_state ~name:None m in
+              check_error_result expected got
+          end
         in
         link_state
       | Assert (Assert_invalid (m, expected)) ->

diff --git a/test/script/reference.t b/test/script/reference.t
@@ -1,6 +1,6 @@
   $ owi script --no-exhaustion reference/address.wast
   $ owi script --no-exhaustion reference/align.wast
-  expected alignment must not be larger than natural but there was no error
+  expected malformed memop flags but there was no error
   [7]
   $ owi script --no-exhaustion reference/binary-leb128.wast
   $ owi script --no-exhaustion reference/binary.wast

diff --git a/test/script/reference_opt.t b/test/script/reference_opt.t
@@ -1,6 +1,6 @@
   $ owi script --no-exhaustion --optimize reference/address.wast
   $ owi script --no-exhaustion --optimize reference/align.wast
-  expected alignment must not be larger than natural but there was no error
+  expected malformed memop flags but there was no error
   [7]
   $ owi script --no-exhaustion --optimize reference/binary-leb128.wast
   $ owi script --no-exhaustion --optimize reference/binary.wast