Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linguist-generated #920

Closed

Conversation

Halbaroth
Copy link
Collaborator

@Halbaroth Halbaroth commented Oct 30, 2023

Fix the PR #830. The syntax I used for the tag linguist-generated was wrong. Should work now :)

@Halbaroth Halbaroth added this to the 2.6.0 milestone Oct 30, 2023
@Halbaroth Halbaroth force-pushed the linguist-generated-dune-inc-bis branch from 6fce334 to b71f99f Compare October 30, 2023 15:48
Fix the PR OCamlPro#830. The syntax I used for the `tag` linguist-generated was
wrong. Should work now :)
Copy link
Collaborator

@bclement-ocp bclement-ocp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is working with the current syntax? I have the message "Some generated files are not rendered by default" on the dune.inc file already.

image

@Halbaroth
Copy link
Collaborator Author

Halbaroth commented Oct 30, 2023

It seems you are right... there is no way to prevent GitHub to count the lines modified in dune.inc. I thought the feature didn't work.

@Halbaroth Halbaroth closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants