Add ml_z_extract_small JS stub #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml_z_extract_small was added as a fast path in ZArith 1.13. It is not (yet) supported by zarith_stubs_js. Since it is a fast path for ml_z_extract, we can simply call ml_z_extract in missing_primitives.js for the time being. Fixes OCamlPro#895
Halbaroth
approved these changes
Oct 16, 2023
|
Yeah, CI issue seems unrelated, forcing the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ml_z_extract_small was added as a fast path in ZArith 1.13. It is not (yet) supported by zarith_stubs_js. Since it is a fast path for ml_z_extract, we can simply call ml_z_extract in missing_primitives.js for the time being.
Fixes #895