Remove Util.failwith

[Stevendeo]

The file :

(set-logic ALL)

(declare-const x Float16)

produces an error in alt-ergo, but exits with code 2. This PR fixes this issue to make it fail properly with a code 1, plus removes the Util.failwith function to replace it with its Fmt equivalent.

[Halbaroth]

I guess we can use Fmt.kstr here :)? Besides we can move the function in Utils.

[Stevendeo]

Errors depends on Util unfortunately, but I can use Fmt

[bclement-ocp]

LGTM.

There is a trend in your PRs of saying they do one thing "and also, by the way, another thing". A common guideline is that if what the PR does cannot be described without using the word "and", it should not be a single PR but rather two (or more) separate PRs.

Here this is not the case because the description of the PR should be "Remove Util.failwith" (where it is sometimes replaced with Fmt.failwith and sometimes replaced by an appropriate specific exception), but please keep that in mind :)

[Stevendeo]

There is a trend in your PRs of saying they do one thing "and also, by the way, another thing". A common guideline is that if what the PR does cannot be described without using the word "and", it should not be a single PR but rather two (or more) separate PRs.

You're right, I have a hard time staying focused on a single thing; I will make efforts to focus on one single task on my next PRs :)

[bclement-ocp]

You're right, I have a hard time staying focused on a single thing; I will make efforts to focus on one single task on my next PRs :)

FWIW to counteract this, I often work on a branch where I do multiple things at once, then use git checkout -p to extract more focused commits that make it into PRs.