Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support (get-info :all-statistics) and refactoring Profiling module #863

Merged
merged 9 commits into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions alt-ergo-lib.opam
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ depends: [
"ppx_blob" {>= "0.7.2"}
"camlzip" {>= "1.07"}
"odoc" {with-doc}
"ppx_deriving"
]
conflicts: [
"ppxlib" {< "0.30.0"}
Expand Down
11 changes: 2 additions & 9 deletions src/bin/common/signals_profiling.ml
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,6 @@

open AltErgoLib

let timers = Timers.empty ()

let get_timers () = timers

let init_sigterm_6 () =
(* what to do with Ctrl+C ? *)
Sys.set_signal Sys.sigint(*-6*)
Expand All @@ -58,7 +54,7 @@ let init_sigterm_11_9 () =
(Sys.Signal_handle
(fun _ ->
Profiling.print true (Steps.get_steps ())
timers (Options.Output.get_fmt_diagnostic ());
(Options.Output.get_fmt_diagnostic ());
exit 1
)
)
Expand All @@ -71,7 +67,7 @@ let init_sigterm_21 () =
Sys.set_signal Sys.sigprof (*-21*)
(Sys.Signal_handle
(fun _ ->
Profiling.print false (Steps.get_steps ()) timers
Profiling.print false (Steps.get_steps ())
(Options.Output.get_fmt_diagnostic ());
)
)
Expand All @@ -84,10 +80,7 @@ let init_sigalarm () =

let init_profiling () =
if Options.get_profiling () then begin
Timers.reset timers;
assert (Options.get_timers());
Timers.set_timer_start (Timers.start timers);
Timers.set_timer_pause (Timers.pause timers);
Profiling.init ();
end

Expand Down
3 changes: 0 additions & 3 deletions src/bin/common/signals_profiling.mli
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@
(* *)
(**************************************************************************)

(** Return a timer *)
val get_timers : unit -> AltErgoLib.Timers.t

(** Initialise signals handler for system signals *)
val init_signals : unit -> unit

Expand Down
14 changes: 12 additions & 2 deletions src/bin/common/solving_loop.ml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ let main () =
if Options.get_profiling() then
Profiling.print true
(Steps.get_steps ())
(Signals_profiling.get_timers ())
(Options.Output.get_fmt_diagnostic ());
(* If the status of the SAT environment is inconsistent,
we have to drop the partial model in order to prevent
Expand Down Expand Up @@ -393,6 +392,7 @@ let main () =

let handle_option st_loc name (value : DStd.Term.t) =
match name, value.term with
(* Smtlib2 regular options *)
| ":regular-output-channel", Symbol { name = Simple name; _ } ->
Options.Output.create_channel name
|> Options.Output.set_regular
Expand Down Expand Up @@ -445,6 +445,13 @@ let main () =
| ":random-seed"), _
->
unsupported_opt name
(* Alt-Ergo custom options *)
| ":profiling", Symbol { name = Simple level; _ } ->
begin
match float_of_string_opt level with
| None -> print_wrn_opt ~name st_loc "nonnegative integer" value
bclement-ocp marked this conversation as resolved.
Show resolved Hide resolved
| Some i -> Options.set_profiling true i
end
| _ ->
unsupported_opt name
in
Expand Down Expand Up @@ -485,7 +492,10 @@ let main () =
pp_reason_unknown st
| ":version" ->
print_std Fmt.string Version._version
| ":all-statistics"
| ":all-statistics" ->
Printer.print_std "%t" Profiling.print_statistics;
if not (Options.get_profiling ()) then
warning "Profiling disactivated (try --profiling)"
bclement-ocp marked this conversation as resolved.
Show resolved Hide resolved
| ":assertion-stack-levels" ->
unsupported_opt name
| _ ->
Expand Down
2 changes: 1 addition & 1 deletion src/lib/dune
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
alt_ergo_prelude
fmt
)
(preprocess (pps ppx_blob))
(preprocess (pps ppx_blob ppx_deriving.show ppx_deriving.enum ppx_deriving.fold))
(preprocessor_deps (glob_files ../preludes/*.ae))

; .mli only modules *also* need to be in this field
Expand Down
Loading
Loading