Remove infer_input_format option #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of `infer_input_format` / `input_format` is confusing: - By default, `infer_input_format` is `true` - We only ever look at `input_format` if `infer_input_format` is `false` - We only set `infer_input_format` to `false` when we explicitly set `input_format` to a non-default value Since we can never look at the default value of `input_format`, this patch removes `infer_input_format` and makes `input_format` an `option` to better align with the way it is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of
infer_input_format/input_formatis confusing:infer_input_formatistrueinput_formatifinfer_input_formatisfalseinfer_input_formattofalsewhen we explicitly setinput_formatto a non-default valueSince we can never look at the default value of
input_format, this patch removesinfer_input_formatand makesinput_formatanoptionto better align with the way it is used.