Increase minimal version of Zarith #816
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to increase the minimal version of
Zarith
. Indeed, the functionQ.of_string
does not support decimal notation beforeZarith > 1.11
. See ocaml/Zarith#65This issue cannot be detected by the opam repository CI as the command
dune build @runtest-ci
isn't running by this CI and the issue occurs only using both a switch with lower bounds and the frontend dolmen.I run tests locally and it should work now.
To prevent such situations from recurring, I suggest to use the alias
runtest
to run all the tests andruntest-something
to run locally quick tests.As soon as opam 2.2 is stable, I will modify the CI in order to check lower bounds.
I also add
ppxlib < 0.30.0
as a conflict instead of a dependency.We have to backport this PR again...