Remove My_zip module #1264
Remove My_zip module #1264
Conversation
We should use the same test as we only want to check that Alt-Ergo can unzip correctly the input file if its name has the form: name.format.zip.
The module `My_Zip` contains only function which is called once in `Solving_loop`. This commit cleans the code and move it in `Solving_loop` directly. Technically, `Solving_loop` is a part of the binary, but as everyone knows, most of the code of this module will be push into the library after we design a good API.
They did not contain the same test (up to translation). We only want to check that Alt-Ergo can unzip archives and recognize the right format based on the name of the archive. It would be annoying that one of them fails because the zipped test fails. |
Ah yes this is the issue that one is zipped with compression and not the other. We should keep one test for compressed zip and one test for uncompressed zip however. Can we instead rename them to be explicit (e.g. |
|
Now, there are both uncompressed: and I guess that If you want, I can force the method with the option |
|
Please do keep a test with a compressed zip file. It is a use case we want to support so it should be in the test suite. |
|
Done. The option |
Add a padding comment in both tests to ensure that zip won't choose the store method while compressing them.
The module
My_Zipcontains only function which is called once inSolving_loop. This commit cleans the code and move it inSolving_loopdirectly. Technically,Solving_loopis a part of thebinary, but as everyone knows, most of the code of this module will be
push into the library after we design a good API.
This PR replaces #1248