-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Lib_usage.ml
#1062
Update Lib_usage.ml
#1062
Conversation
Actually, @bclement-ocp suggested to remove the compilation of Do you have any reason? I can move the |
I admit I don't remember the details but I believe it was actually a I am not sure why I suggested to not build the examples; I think the issue is lack of a |
(executable
(name Lib_usage)
(public_name lib-usage)
(package alt-ergo-lib)
(libraries AltErgoLib)
(modules Lib_usage)
) ? |
I am not sure; I think we need to make sure that all of the following are OK (again my memory is fuzzy but if I recall correctly the examples were run for the parsers): $ dune clean && dune build -p alt-ergo-lib @runtest
$ dune clean && dune build -p alt-ergo-parsers @runtest
$ dune clean && dune build -p alt-ergo @runtest If all of these pass and the |
cc69441
to
b9ad2f9
Compare
We add the executable `lib_usage` into the package `alt-ergo-lib` but we don't install it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM provided that the aforementioned CLI commands succeed 👍
We have changed a bit the API of the AE library but the
Lib_usage.ml
isn't up to date.I don't know why I prevented
Dune
from compiling this file, so I restore the compilation and the test of this file.