-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] module survey_odoo_debranding #130
base: 16.0
Are you sure you want to change the base?
Conversation
mathben
commented
Aug 22, 2024
- remove Powered by Odoo into survey website
8ea5a22
to
a731bea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check CI errors
a731bea
to
f59ac18
Compare
I recommend you setting up pre-commit in your local to fix it in advance to pushing: https://github.com/OCA/maintainer-tools/wiki/Install-pre-commit |
5ebac29
to
3e2cd8a
Compare
<!-- Remove "Powered by Odoo" --> | ||
<template | ||
id="frontend_layout_remove_brand" | ||
inherit_id="survey.layout" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remove customize_show=True
I need to retest it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test done, it works without customize_show=True
Thanks for your support @chienandalu |
I'd say the issue was that For the test cover, it isn't blocking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 👍
- remove Powered by Odoo into survey website
3e2cd8a
to
66531a8
Compare
Thanks. |