Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] module survey_odoo_debranding #130

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

mathben
Copy link

@mathben mathben commented Aug 22, 2024

  • remove Powered by Odoo into survey website

@mathben mathben force-pushed the 16.0_survey_odoo_debranding branch from 8ea5a22 to a731bea Compare August 24, 2024 05:39
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check CI errors

@chienandalu
Copy link
Member

I recommend you setting up pre-commit in your local to fix it in advance to pushing: https://github.com/OCA/maintainer-tools/wiki/Install-pre-commit

<!-- Remove "Powered by Odoo" -->
<template
id="frontend_layout_remove_brand"
inherit_id="survey.layout"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remove customize_show=True
I need to retest it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test done, it works without customize_show=True

@mathben
Copy link
Author

mathben commented Nov 15, 2024

Thanks for your support @chienandalu
About the test cover, I am base with this module : https://github.com/OCA/website/blob/16.0/website_odoo_debranding/hooks.py#L16
What do you think?
And this sentence "- XML changes in website are made using 'customize_show=True'" is not good anymore, because I remove customize_show=True because it fails "test / test with OCB (pull_request)"

@chienandalu
Copy link
Member

I'd say the issue was that customize_show is a field introduced by portal and survey doesn't have it in its dependency chain. In any case, you don't need for the task.

For the test cover, it isn't blocking.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍

- remove Powered by Odoo into survey website
@mathben
Copy link
Author

mathben commented Nov 15, 2024

Thanks.
So, I remove this comment into hooks.py
# - XML changes in website are made using 'customize_show=True'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants