Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FW] [14.0] shipment_advice: load a transfer in multiple shipments + list goods that could be loaded (new smart button) #156

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

giarve
Copy link
Contributor

@giarve giarve commented Nov 17, 2024

Port of #96 from 14.0 to 16.0.

I realised these commits were missing. In 16.0 the leave_open is handled by leaving an error on SA when confirming the Shipment Advice. In 14.0 it was just validated. That's why you will see I changed some tests and added flags to handle that with a leave_open policy it should not error. This can be discussed.

Porting the second commit will unlock:
OCA/wms#944

Two use cases here:

1) Load all the transfer lines in two shipments:
    => Validate the first shipment: the transfer is not validated
    => Validate the second shipment: the transfer is then validated

2) No backorder policy, load partially a transfer, validate the shipment,
load the remaining goods in a second shipment and validate it:
    => the transfer is not validated during the validation of the first
    shipment (left open thanks to the BO policy)
    => the transfer is then validated during the validation of the
    second shipment.
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the forward port. LGTM (no tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants