[14.0][FIX] shipment_advice: do not copy shipment advice id on moves

[TDu]

In the case of partially receiving goods, the backorder moves created should not be included in the shipment advice being processed. But it probably makes sense for outgoing move as well.

[mt-software-de]

Thank you.

Should it also be copy=False on stock.move.line?

[TDu]

Thank you.

Should it also be copy=False on stock.move.line?

I do not think it is necessary, at least for what we are trying to fix here, which is handling backorder correctly.

[mt-software-de]

I my opinion this should also be False for stock.move.line, it should be set by

stock-logistics-transport/shipment_advice/models/stock_move_line.py

Line 40 in 487d71c

def _load_in_shipment(self, shipment_advice):

and not from a copy.

[mt-software-de]

LGTM

[simahawk]

LG

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[mt-software-de]

@jbaudoux could you merge this one please?

[mt-software-de]

@jbaudoux could you merge this one please?

ping @OCA/logistics-maintainers ?

[jbaudoux]

What happens when you process with shopfloor reception and the move is split when you set destination ? Does it remains planned?

[mt-software-de]

What happens when you process with shopfloor and the move is split when you set destination ? Does it remains planned?

For shopfloor_delivery_shipment https://github.com/OCA/wms/blob/14.0/shopfloor_delivery_shipment/services/delivery_shipment.py we should be good.

For shopfloor_reception / shopfloor_reception_shipment_advice this could lead to an error, so i wouldn't remain planned.

I think therefor we should extend _prepare_move_split_vals this would be used in https://github.com/OCA/wms/blob/7bca8fc3bf20d78a161010959c39edaca7c9bb8e/shopfloor_reception/services/reception.py#L1306 which is called by _split

Also there is done_action https://github.com/OCA/wms/blob/7bca8fc3bf20d78a161010959c39edaca7c9bb8e/shopfloor_reception/services/reception.py#L963 which validates the transfer.

[jbaudoux]

shopfloor_reception_shipment_advice needs to be adapted accordingly

[mt-software-de]

shopfloor_reception_shipment_advice needs to be adapted accordingly

I think we can overwrite _prepare_move_split_vals within this PR and set shipment advice id, if a specific context key is set.
This context key can then be set in shopfloor_reception_shipment_advice https://github.com/OCA/wms/blob/7bca8fc3bf20d78a161010959c39edaca7c9bb8e/shopfloor_reception/services/reception.py#L963 and https://github.com/OCA/wms/blob/7bca8fc3bf20d78a161010959c39edaca7c9bb8e/shopfloor_reception/services/reception.py#L1282

@TDu when do you plan to do this?

[TDu]

Rebased.
I have added a context key in _prepare_move_split_vals
I am working on the change in shopfloor_reception_shipment_advice but struggling with the tests there...

[mt-software-de]

I just discussed this topic, again. And right now i don't know where this requirement is coming from anymore.
From my point of view i don't see any reason why the link shouldn't be copied within the reception scenario.
We will schedule a meeting for this next week.

[jbaudoux]

cc @rousseldenis (fyi)

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[rousseldenis]

@TDu @jbaudoux Why this key of context ?

Shouldn't it be possible to use the stock rule that has created the move and a property on it to do the same ?

[mt-software-de]

Just as Information, we discussed this topic some weeks ago and there was no scenario where the id should not be copied. All of the cases in shopfloor as example would need the value.
So i think we should close this one.

[TDu]

It seems that this PR is not used on customer projects, I would say it can be closed.
Although I think the copy=False makes some sense.