[16.0][MIG] sale_invoice_plan, standard migration to 16.0 #2988
Conversation
kittiu
changed the title
kittiu
changed the title
kittiu
force-pushed
the
16.0-mig-sale_invoice_plan_kittiu
branch
2 times, most recently
from
aed09d1 to
8804c82
Compare
| rec.invoice_plan_process = True | ||
| continue | ||
| rec.invoice_plan_process = False | ||
| inv_or_adv = rec.invoice_status == "to invoice" or ( |
There was a problem hiding this comment.
@dreispt just FYI, I saw this part of code that you try to refactor on your code is incorrect. This might be the reason that advance is not working?
I try to refactor here too, this will remain the same logic and it works for me.
|
/ocabot migration sale_invoice_plan |
|
@kittiu What's the status of this ? |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
@rvalyi your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2988-by-rvalyi-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Hum there was an error in the tests during the merge strangely: 2024-12-04 09:44:58,901 562 INFO odoo odoo.tests.suite: ====================================================================== During handling of the above exception, another exception occurred: Traceback (most recent call last): cc @kittiu |
|
Cc @Saran440 can you help? |
|
@kittiu Could you rebase then ? |
| } | ||
|
|
||
| # Create base account to simulate a chart of account | ||
| user_type_payable = cls.env.ref("account.data_account_type_payable") |
There was a problem hiding this comment.
| user_type_payable = cls.env.ref("account.data_account_type_payable") | |
| user_type_payable = self.company_data['default_account_payable'] |
kittiu
force-pushed
the
16.0-mig-sale_invoice_plan_kittiu
branch
from
0c34511 to
adaaa45
Compare
|
@kittiu I think you should have rebased instead of merging the 16.0 branch. Could you fix that? Also, if you could amend your commit message as requested by @rousseldenis , after that I can merge it. |
…f the product's unit of measure
Currently translated at 100.0% (75 of 75 strings) Translation: sale-workflow-15.0/sale-workflow-15.0-sale_invoice_plan Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_invoice_plan/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-15.0/sale-workflow-15.0-sale_invoice_plan Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-15-0/sale-workflow-15-0-sale_invoice_plan/
TheerayutEncoder
force-pushed
the
16.0-mig-sale_invoice_plan_kittiu
branch
from
9c9b2cd to
bebe744
Compare
| @@ -153,12 +154,13 @@ def _get_amount_invoice(self, invoices): | |||
| amount_invoiced = sum(lines.mapped("price_subtotal")) | |||
| return amount_invoiced | |||
|
|
|||
| @api.depends("invoice_move_ids.state") | |||
There was a problem hiding this comment.
@kittiu What's the impact of this on existing database in terms of upgrade performance?
There was a problem hiding this comment.
Really not sure about this. But I doubt that this will be relevant to update the module? Since state is not changing. Do you foresee problem?
|
Commit and test script have fixed. |
|
This PR has the |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 7e08a99. Thanks a lot for contributing to OCA. ❤️ |
Standard migration