[17.0][ADD] partner_title_active #1869
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoux
reviewed
Oct 21, 2024
vvrossem
reviewed
Oct 30, 2024
Comment on lines
13
to
17
| def test_01_partner_title(self): | ||
| partner = self.Partner.create({"name": "A Partner"}) | ||
| self.assertTrue(partner.active, "Partner should be active by default") | ||
| partner.action_archive() | ||
| self.assertFalse(partner.active, "Partner should be inactive after archiving") |
There was a problem hiding this comment.
This doesn't test whether the title is active or not 😕
There was a problem hiding this comment.
Why? Can you describe pls a test scenario you think is more suitable?
There was a problem hiding this comment.
The partner that is created doesn't have a title set.
The scenario might be:
- create a partner with a title (res.partner.title)
- test the title is active
- archive the title, assert it is not active
There was a problem hiding this comment.
ok, I'll adapt, thanks
There was a problem hiding this comment.
ahaha @vvrossem , I've just get that I was archiving the partner and not the title 🥲
good catch, shame on me!
yankinmax
force-pushed
the
add-partner_title_active
branch
2 times, most recently
from
d057e9f
to
afeaeea
Compare
yankinmax
force-pushed
the
add-partner_title_active
branch
from
afeaeea
to
60266ec
Compare
|
LGTM |
Abimael1321
approved these changes
Nov 8, 2024
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
Activefield to the partner title model to be able to deactivate titles without deleting them