Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] partner_data_vies_populator #1642

Open
wants to merge 14 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] partner_data_vies_populator #1642

wants to merge 14 commits into from

Conversation

dreispt
Copy link
Member

@dreispt dreispt commented Jan 11, 2024 •
edited
Loading

Includes improvement:

  • [IMP] partner_data_vies_populator: populate Zip code and City

@dreispt dreispt force-pushed the 16.0-mig-partner_data_vies_populator branch 5 times, most recently from a837f35 to 8fbbfd0 Compare January 11, 2024 01:51
@dreispt dreispt force-pushed the 16.0-mig-partner_data_vies_populator branch 2 times, most recently from 6ffaf96 to 8d99650 Compare January 11, 2024 02:03
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024
@dreispt
Copy link
Member Author

dreispt commented May 16, 2024

Ping!

bosd
bosd reviewed May 16, 2024
View reviewed changes
partner_data_vies_populator/readme/INSTALL.rst Outdated
@@ -0,0 +1,2 @@
This module require the `python-stdnum <https://pypi.org/project/python-stdnum/>`_ library.
As Odoo itself depends on this librairy, it should already be installed on your system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
As Odoo itself depends on this librairy, it should already be installed on your system.
As Odoo itself depends on this library, it should already be installed on your system.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt Please attend to this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bosd Fixed!

@bosd
Copy link
Contributor

bosd commented May 16, 2024

Would like to do a func rev. Of the new feature. But runboat is not available.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 19, 2024
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 22, 2024
@bosd
Copy link
Contributor

bosd commented Sep 23, 2024

@dreispt can you recreate a runboat?

feketemihai and others added 13 commits September 23, 2024 16:39
@feketemihai @dreispt
[MIG] partner_create_by_vat: Migration to 13.0
3ddcbf7
@oca-travis @dreispt
[UPD] Update partner_data_vies_populator.pot
d6e3a08
@OCA-git-bot @dreispt
[UPD] README.rst
3d91a43
@alexis-via @dreispt
[MIG] partner_data_vies_populator from v13 to v14
1f30edf 
Improve error handling to avoid crash when Internet connectivity is down
Read country code from VIES, not from VAT number
No update when VAT number is invalid
Improve tests
@dreispt
[UPD] Update partner_data_vies_populator.pot
209755b
@OCA-git-bot @dreispt
[UPD] README.rst
11a4f44
@OCA-git-bot @dreispt
partner_data_vies_populator 14.0.1.0.1
10f81b0
@klodr @dreispt
Added translation using Weblate (French)
25964f5
@klodr @dreispt
Translated using Weblate (French)
1411827 
Currently translated at 100.0% (5 of 5 strings)

Translation: partner-contact-14.0/partner-contact-14.0-partner_data_vies_populator
Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_data_vies_populator/fr/
@NL66278 @dreispt
[FIX] partner_data_vies_populator: correct company name in test
6d231e1
@jdidderen-noviat @dreispt
[MIG] partner_data_vies_populator: Migration to 15.0
038806c
@dreispt
[IMP] partner_data_vies_populator: pre-commit stuff
f62459c
@dreispt
[MIG] partner_data_vies_populator: Migration to 16.0
1c05db5
@dreispt dreispt force-pushed the 16.0-mig-partner_data_vies_populator branch from 8d99650 to 96e9267 Compare September 23, 2024 15:42
@dreispt
Copy link
Member Author

dreispt commented Sep 23, 2024

@bosd Rebased and pushed. That should make it available on Runboat.

bosd
bosd reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!
Functional test:
The code for updating zip code and city name is not working for VAT numbers from the Netherlands.
Quick code review, minor grammar changes

partner_data_vies_populator/README.rst

So, when the data is retrieved, it will try to populate the *City* and *Zip* fields
from the last line of the address.
T he *Street* field will contain the remaining information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
T he *Street* field will contain the remaining information.
The *Street* field will contain the remaining information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt Please attend to this one

partner_data_vies_populator/readme/INSTALL.rst Outdated
@@ -0,0 +1,2 @@
This module require the `python-stdnum <https://pypi.org/project/python-stdnum/>`_ library.
As Odoo itself depends on this librairy, it should already be installed on your system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dreispt Please attend to this?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 29, 2024
@dreispt dreispt force-pushed the 16.0-mig-partner_data_vies_populator branch from 96e9267 to a29efba Compare November 16, 2024 19:44
@dreispt dreispt requested a review from bosd November 16, 2024 19:44
@bosd
Copy link
Contributor

bosd commented Nov 27, 2024

@dreispt When I enter a ducth vat. Nothing happens.
NL.0011.72.359.B.01 or with NL001172359B01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexis-via alexis-via Awaiting requested review from alexis-via

@bosd bosd Awaiting requested review from bosd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@dreispt @bosd @feketemihai @oca-travis @OCA-git-bot @alexis-via @klodr @NL66278 @jdidderen-noviat