Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][ADD] hr_holidays_leave_self_approve #70

Merged
merged 1 commit into from
May 2, 2024

Conversation

florentx
Copy link

No description provided.

@florentx florentx force-pushed the hr_holidays_leave_self_approve branch from 13d1368 to 264fd61 Compare April 11, 2023 12:11
@florentx florentx changed the title [ADD] hr_holidays_leave_self_approve [15.0][ADD] hr_holidays_leave_self_approve Apr 11, 2023
@florentx florentx force-pushed the hr_holidays_leave_self_approve branch 6 times, most recently from 4aa6e0f to 4d973e1 Compare April 12, 2023 09:15
@rafaelbn
Copy link
Member

rafaelbn commented May 5, 2023

I think an better explanation should be in README as this can be done in Odoo Community without any module by:

  • Setting approval to "no validation" or (better)
  • Just setting "By Employee's Approver" and changing the domain of the field in the employee to it self.

Just curious, I would not use this module even when I allow my employees self-allow approvals 😄

Not blocking anything! Regards

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 3, 2023
@florentx
Copy link
Author

florentx commented Sep 4, 2023

I think an better explanation should be in README as this can be done in Odoo Community without any module by:

* Setting approval to "no validation" or (better)

* Just setting "By Employee's Approver" and changing the domain of the field in the employee to it self.

This add-on is useful for our use case because:

  1. They want a validation, even if it is a self validation
  2. Changing the domain of the field to the employee itself does not work because of this check in standard (Odoo 15)
# File "addons/hr_holidays/models/hr_leave.py"

                    if holiday.employee_id == current_employee:
                        raise UserError(_('Only a Time Off Manager can approve/refuse its own requests.'))

@simahawk simahawk removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 4, 2023
@florentx florentx force-pushed the hr_holidays_leave_self_approve branch from 4d973e1 to 545ce17 Compare September 4, 2023 07:41
@florentx florentx force-pushed the hr_holidays_leave_self_approve branch from 545ce17 to 9fa9ec3 Compare September 4, 2023 07:45
Copy link

github-actions bot commented Jan 7, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 7, 2024
@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-70-by-gurneyalex-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 30, 2024
Signed-off-by gurneyalex
@OCA-git-bot
Copy link
Contributor

@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-70-by-gurneyalex-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 4, 2024
@dreispt
Copy link
Member

dreispt commented May 2, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-70-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c3b3caf into OCA:15.0 May 2, 2024
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cfbfd48. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants