Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] hr_holidays_public: fixed action_validate() override #115

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[16.0][FIX] hr_holidays_public: fixed action_validate() override #115

merged 1 commit into from
Jul 1, 2024

Conversation

dalonsod
Copy link

Forward-port of #114

@dalonsod
Copy link
Author

Tests fail due to hr_holidays_leave_auto_approve addon.

This was referenced Mar 17, 2024
Merged
Merged
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jul 1, 2024
@pedrobaeza
Copy link
Member

Can you check CI?

@dalonsod dalonsod force-pushed the 16.0-fix-hr_holidays_public-validatesingleton branch from a1ffc2f to 1dd8fd9 Compare July 1, 2024 11:43
@dalonsod
Copy link
Author

dalonsod commented Jul 1, 2024

Done!

pedrobaeza
pedrobaeza approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-115-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-115-by-pedrobaeza-bump-patch:16.0 failed with output:

To https://github.com/OCA/hr-holidays
 ! [remote rejected] 16.0-ocabot-merge-pr-115-by-pedrobaeza-bump-patch -> 16.0 (cannot lock ref 'refs/heads/16.0': is at bdf07a37e5b68bdfac88a664f839784776295882 but expected 5d469dc8386546b78e32c69db2e31512bf6799cd)
error: failed to push some refs to 'https://***@github.com/OCA/hr-holidays'

@OCA-git-bot OCA-git-bot merged commit 43f9f88 into OCA:16.0 Jul 1, 2024
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at bdf07a3. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dalonsod @pedrobaeza @OCA-git-bot @AaronHForgeFlow @dariodelzozzo