[15.0][FIX]hr_holidays_calendar_event_privacy: Fix test in time #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grindtildeath
changed the title
gurneyalex
approved these changes
Feb 26, 2024
pedrobaeza
requested changes
Mar 17, 2024
| @@ -24,15 +27,15 @@ def _new_leave_request(cls, date_from, date_to): | |||
| def test_calendar_event_privacy(self): | |||
| self.assertEqual(self.leave_type.calendar_event_privacy, "confidential") | |||
| leave = self._new_leave_request( | |||
| fields.Date.today() + timedelta(days=12), | |||
| fields.Date.today() + timedelta(days=13), | |||
| fields.Date.today() + timedelta(days=2), | |||
There was a problem hiding this comment.
I don't get why are you changing this data.
There was a problem hiding this comment.
@pedrobaeza I'm not sure, but this may fix errors like this one: https://github.com/OCA/hr-holidays/actions/runs/8315045201/job/22752936701?pr=114 (PR #114)
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 9cefb71. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #112