[IMP] account_statement_base: no need to depend on account_reconcile_model_oca tests #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexis-via, |
pedrobaeza
approved these changes
Nov 14, 2024
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at cd09680. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 16.0, a PR was added to "Link to Account Move Lines in Statements"
it was forward ported to 17.0, which introduced a dep on
account_reconcile_model_ocafor tests.this dependency is strictly needed and actually unwelcome in some contexts where we might want
accountant_statement-importmodules withoutaccount_reconcile_model_oca.so this PR: will simplify the test, it will no longer have a dependency on
account_reconcile_model_oca, making the modules inaccountant_statement-importdepend onaccount_statement_baseand will no longer have overlapping dependencies fromaccount_reconcile_model_oca.