[FIX] account_reconcile_oca: Make it work with foreign currency #577

etobella · 2023-08-19T06:58:56Z

Fixes #574

@nagybal Can you test it please?

etobella · 2023-08-19T07:11:33Z

Still missing a test in order to leave this documented, but should be functional 😄

nagybal · 2023-08-21T09:24:15Z

@etobella Dear Enric! Thank You for taking a look into it!

I have updated the account_reconcile_oca module only.
Gave it a new version, so I can verify it on the instance too.

Unfortunately, the issue is the same:

The widget takes the amount of the main currency and puts it where the amount in the secondary currency should be.

I can manually correct the amount, but odoo still does not allow to reconcile:

It messes up the currencies again

The move (BNK2/2023/00032 (2023-03-16)) is not balanced.
The total of debits equals 1,919,047 Ft and the total of credits equals 5,037 Ft.
You might want to specify a default account on journal "Bank (EUR)" to automatically balance each move.

etobella · 2023-08-21T09:36:39Z

Did you use the one from the PR? I mean, when you come from an external currency, it should show the in currency column 🤔

nagybal · 2023-08-21T09:42:50Z

I have used the below files. I just checked a couple of lines with nano on the server. They are the files from the PR #577

etobella · 2023-08-21T09:44:04Z

Ok, I will check again, thanks!

etobella · 2023-08-21T09:58:31Z

I added some more info in order to show when a reconcile involves foreign currencies. You can use runboat in order to test it.

nagybal · 2023-08-21T11:05:22Z

You have to create a new bank account (a new journal)!
http://oca-account-reconcile-16-0-pr577-a52523510ef3.runboat.odoo-community.org/

In my case:
Base currency: HUF

Statement: EUR
Bank Account: EUR

I should be possible to reconcile EUR with EUR!

nagybal · 2023-08-21T11:16:03Z

Using Your USD EUR example, the problem occurs on the second bank account:

etobella · 2023-08-21T11:36:35Z

I see!!! The problem is raised when we use a journal from a different currency!

Thanks!

etobella · 2023-08-21T13:11:05Z

Well, now it worked for me. Let's see if it works for you 😄

nagybal · 2023-08-26T06:49:10Z

@etobella unfortunately I have little, basically no knowledge of coding. I tried to figure out what have You added. Shall I look at this database?
http://oca-account-reconcile-16-0-pr577-994ff0a16c3a.runboat.odoo-community.org/

etobella · 2023-08-26T06:56:46Z

You just need to reproduce the error in this runboat database. If you cannot reproduce it again and all works as expected, then it is fixed. Don't worry about the code, I was looking for a functional review 😁

nagybal · 2023-08-26T08:40:09Z

Then the issue is the same. If You take a look at the runboat database. The base currency is USD the invoice is in HUF and the payment was made in HUF as well. For some reason the reconciliation widget turns the HUF amount into USD. The amount is 500 000 HUF(Ft) and it should stay 500 000 and NOT 1413.71 USD which is the "bookkeeping" amount.

etobella · 2023-08-26T08:59:15Z

I see, the problem comes from the data in "amount in Currency" that is not properly showed. Right now it should work properly. It only failed on the first line.

nagybal · 2023-08-26T09:43:46Z

You can reconcile now. If You have multiple invoices to choose from. This collum should be the amount in currency as well:

ps: The amount in currency changes because of decimal currency. It can be fixed in developer mode.

etobella · 2023-08-26T13:31:43Z

True, I added the field, but it is hidden. BTW, I found a small Odoo issue with that, as an aggregation line is added by default, but it shouldn't 😞 odoo/odoo#133274

nagybal · 2023-08-26T16:11:30Z

odoo/odoo#133274

The two screenshots seem to me identical

etobella · 2023-08-26T16:56:22Z

Look at the footer. In the first one there's a gray line with a black line

…not defined

nagybal · 2023-08-26T21:31:21Z

I just logged in to 49355b2 and changed noting. But if I hit the reconcile button, I get an error straight away:

RPC_ERROR
Odoo Server Error

Traceback (most recent call last):
  File "/opt/odoo/odoo/api.py", line 984, in get
    cache_value = field_cache[record._ids[0]]
KeyError: 8

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/odoo/odoo/fields.py", line 1160, in __get__
    value = env.cache.get(record, self)
  File "/opt/odoo/odoo/api.py", line 991, in get
    raise CacheMiss(record, field)
odoo.exceptions.CacheMiss: 'account.bank.statement.line(8,).can_reconcile'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/odoo/odoo/api.py", line 984, in get
    cache_value = field_cache[record._ids[0]]
KeyError: 8

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/odoo/odoo/fields.py", line 1160, in __get__
    value = env.cache.get(record, self)
  File "/opt/odoo/odoo/api.py", line 991, in get
    raise CacheMiss(record, field)
odoo.exceptions.CacheMiss: 'account.bank.statement.line(8,).reconcile_data_info'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/odoo/odoo/http.py", line 1584, in _serve_db
    return service_model.retrying(self._serve_ir_http, self.env)
  File "/opt/odoo/odoo/service/model.py", line 133, in retrying
    result = func()
  File "/opt/odoo/odoo/http.py", line 1611, in _serve_ir_http
    response = self.dispatcher.dispatch(rule.endpoint, args)
  File "/opt/odoo/odoo/http.py", line 1815, in dispatch
    result = self.request.registry['ir.http']._dispatch(endpoint)
  File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 154, in _dispatch
    result = endpoint(**request.params)
  File "/opt/odoo/odoo/http.py", line 697, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 42, in call_kw
    return self._call_kw(model, method, args, kwargs)
  File "/opt/odoo/addons/web/controllers/dataset.py", line 33, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 461, in call_kw
    result = _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/odoo/api.py", line 448, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/odoo/models.py", line 2982, in read
    return self._read_format(fnames=fields, load=load)
  File "/opt/odoo/odoo/models.py", line 3154, in _read_format
    vals[name] = convert(record[name], record, use_name_get)
  File "/opt/odoo/odoo/models.py", line 5876, in __getitem__
    return self._fields[key].__get__(self, type(self))
  File "/opt/odoo/odoo/fields.py", line 1209, in __get__
    self.compute_value(recs)
  File "/opt/odoo/odoo/fields.py", line 1387, in compute_value
    records._compute_field_value(self)
  File "/opt/odoo/odoo/models.py", line 4211, in _compute_field_value
    fields.determine(field.compute, self)
  File "/opt/odoo/odoo/fields.py", line 100, in determine
    return needle(records, *args)
  File "/opt/odoo/addons/base_sparse_field/models/fields.py", line 52, in _compute_sparse
    values = record[self.sparse]
  File "/opt/odoo/odoo/models.py", line 5876, in __getitem__
    return self._fields[key].__get__(self, type(self))
  File "/opt/odoo/odoo/fields.py", line 1209, in __get__
    self.compute_value(recs)
  File "/opt/odoo/odoo/fields.py", line 1387, in compute_value
    records._compute_field_value(self)
  File "/opt/odoo/odoo/models.py", line 4211, in _compute_field_value
    fields.determine(field.compute, self)
  File "/opt/odoo/odoo/fields.py", line 97, in determine
    return needle(*args)
  File "/mnt/data/odoo-addons-dir/account_reconcile_oca/models/account_bank_statement_line.py", line 326, in _compute_reconcile_data_info
    record.reconcile_data_info = record._default_reconcile_data()
  File "/mnt/data/odoo-addons-dir/account_reconcile_oca/models/account_bank_statement_line.py", line 432, in _default_reconcile_data
    *self._reconcile_data_by_model(
  File "/mnt/data/odoo-addons-dir/account_reconcile_oca/models/account_bank_statement_line.py", line 353, in _reconcile_data_by_model
    for line in reconcile_model._get_write_off_move_lines_dict(
  File "/opt/odoo/addons/account/models/account_reconcile_model.py", line 523, in _get_write_off_move_lines_dict
    if currency.is_zero(balance):
UnboundLocalError: local variable 'balance' referenced before assignment

The above server error caused the following client error:
null

etobella · 2023-08-27T15:49:45Z

The one you used, was a mistake I did. I merged two different PRs by error. You can test the current one 😄

etobella · 2023-08-27T21:26:45Z

Well, I added some tests. It should be ready for review now 😄

rinaldifirdaus · 2023-08-28T10:36:34Z

Functional test in runboat: the debit and credit amount works as expected and can be reconciled now.
but I found that when i register a transaction in bank journal that use secondary currency and reconcile the invoice that use secondary currency, in the statement line the invoice "amount in currency" showing the main currency not the secondary currency. (main currency is USD, secondary is EUR)

I think it should show the currency that in use in the invoice, isn't it?

etobella · 2023-08-28T14:15:56Z

@rinaldifirdaus I checked runboat and I saw your item, but I am unable to reproduce what you did 😢
However, I detected an issue with automatic reconciliation models

…ifferent currency

rinaldifirdaus · 2023-08-28T23:55:09Z

@etobella , thanks for checking!
here's step what i did:

create invoice in EUR
in Bank (EUR) kanban, create transaction (assuming we receive the payment on our EUR account)
fill the label, partner, and EUR amount in "amount" field, then save
invoice and the bank statement will automatically reconciled, and the amount in currency for invoice showing the main currency here

nagybal · 2023-09-04T11:46:56Z

Functional test in runboat: the debit and credit amount works as expected and can be reconciled now.
but I found that when i register a transaction in bank journal that use secondary currency and reconcile the invoice that use secondary currency, in the statement line the invoice "amount in currency" showing the main currency not the secondary currency. (main currency is USD, secondary is EUR)
I think it should show the currency that in use in the invoice, isn't it?

I can not confirm this either. On 91e9748 checks out almost perfectly. You can reconcile but I do not understand this negative sign on front. If this is some kind of accounting stuff. I can live it it.

nagybal · 2023-09-04T17:13:45Z

LGTM

etobella · 2023-09-04T17:21:27Z

/ocabot merge minor

OCA-git-bot · 2023-09-04T17:21:45Z

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-577-by-etobella-bump-minor, awaiting test results.

OCA-git-bot · 2023-09-04T17:29:11Z

Congratulations, your PR was merged at dc7f1ea. Thanks a lot for contributing to OCA. ❤️

etobella linked an issue Aug 19, 2023 that may be closed by this pull request

[16.0] account_reconcile_oca pulls the amount in foreign currency from the wrong field of the statement line #574

Closed

etobella force-pushed the 16.0-foreign branch from 8b7d0f3 to a525235 Compare August 21, 2023 09:57

etobella force-pushed the 16.0-foreign branch from a525235 to 154dc33 Compare August 21, 2023 13:10

etobella force-pushed the 16.0-foreign branch from 154dc33 to 994ff0a Compare August 21, 2023 13:12

[FIX] account_reconcile_oca: Use edit reconcile method in case it is …

8a01c66

…not defined

etobella force-pushed the 16.0-foreign branch from a60ab9d to 7624c3f Compare August 26, 2023 17:19

etobella linked an issue Aug 26, 2023 that may be closed by this pull request

[16.0] account_reconcile_oca reset (unreconcile fails) #579

Closed

etobella force-pushed the 16.0-foreign branch from 49355b2 to 7624c3f Compare August 26, 2023 18:05

etobella force-pushed the 16.0-foreign branch from 7624c3f to 1845ad3 Compare August 27, 2023 16:12

[IMP] account_reconcile_oca: Add some tests for supplier invoices

14007a5

[FIX] account_reconcile_oca: Make it work with foreign currency

c11225c

etobella force-pushed the 16.0-foreign branch from 1845ad3 to c11225c Compare August 27, 2023 16:15

pedrobaeza added this to the 16.0 milestone Aug 28, 2023

pedrobaeza approved these changes Aug 28, 2023

View reviewed changes

[FIX] account_reconcile_oca: Models where failing on default with a d…

91e9748

…ifferent currency

OCA-git-bot added the bot is merging ⏳ label Sep 4, 2023

OCA-git-bot merged commit 8ed9be8 into OCA:16.0 Sep 4, 2023
6 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Sep 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FIX] account_reconcile_oca: Make it work with foreign currency #577

[FIX] account_reconcile_oca: Make it work with foreign currency #577

etobella commented Aug 19, 2023

etobella commented Aug 19, 2023 •

edited

Loading

nagybal commented Aug 21, 2023

etobella commented Aug 21, 2023

nagybal commented Aug 21, 2023

etobella commented Aug 21, 2023

etobella commented Aug 21, 2023

nagybal commented Aug 21, 2023

nagybal commented Aug 21, 2023

etobella commented Aug 21, 2023

etobella commented Aug 21, 2023

nagybal commented Aug 26, 2023

etobella commented Aug 26, 2023

nagybal commented Aug 26, 2023

etobella commented Aug 26, 2023

nagybal commented Aug 26, 2023 •

edited

Loading

etobella commented Aug 26, 2023

nagybal commented Aug 26, 2023

etobella commented Aug 26, 2023

nagybal commented Aug 26, 2023

etobella commented Aug 27, 2023

etobella commented Aug 27, 2023

rinaldifirdaus commented Aug 28, 2023

etobella commented Aug 28, 2023

rinaldifirdaus commented Aug 28, 2023

nagybal commented Sep 4, 2023

nagybal commented Sep 4, 2023

etobella commented Sep 4, 2023

OCA-git-bot commented Sep 4, 2023

OCA-git-bot commented Sep 4, 2023

[FIX] account_reconcile_oca: Make it work with foreign currency #577

[FIX] account_reconcile_oca: Make it work with foreign currency #577

Conversation

etobella commented Aug 19, 2023

etobella commented Aug 19, 2023 • edited Loading

nagybal commented Aug 21, 2023

etobella commented Aug 21, 2023

nagybal commented Aug 21, 2023

etobella commented Aug 21, 2023

etobella commented Aug 21, 2023

nagybal commented Aug 21, 2023

nagybal commented Aug 21, 2023

etobella commented Aug 21, 2023

etobella commented Aug 21, 2023

nagybal commented Aug 26, 2023

etobella commented Aug 26, 2023

nagybal commented Aug 26, 2023

etobella commented Aug 26, 2023

nagybal commented Aug 26, 2023 • edited Loading

etobella commented Aug 26, 2023

nagybal commented Aug 26, 2023

etobella commented Aug 26, 2023

nagybal commented Aug 26, 2023

etobella commented Aug 27, 2023

etobella commented Aug 27, 2023

rinaldifirdaus commented Aug 28, 2023

etobella commented Aug 28, 2023

rinaldifirdaus commented Aug 28, 2023

nagybal commented Sep 4, 2023

nagybal commented Sep 4, 2023

etobella commented Sep 4, 2023

OCA-git-bot commented Sep 4, 2023

OCA-git-bot commented Sep 4, 2023

etobella commented Aug 19, 2023 •

edited

Loading

nagybal commented Aug 26, 2023 •

edited

Loading