Generalise the report generation for ROBOT report and FP3 and FP7 reports #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orts When fixing the incompleteness of ROBOT report generation, I didn't realise it was also used for the FP3 and FP7 reports, so I made it more general now. Change default value for `limitlines` to 50 when generating FP reports instead changing in two places in the makefile. Only assert error_count_level and error_count_rule when it's the ROBOT report Add condition in the template to show types of error and error breakdown only when the it's ROBOT report Generalise the row values in the table Only change row colour accordingly to error level when it's the ROBOT report
matentzn
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
When fixing the incompleteness of ROBOT report generation, I didn't realise it was also used for the FP3 and FP7 reports, so I made it more general now.
limitlinesto 50 when generating FP reports instead changing in two places in the makefile