Fixed issue on URL resolver message #552
Conversation
Moved user_to uppercase to a different function
| @@ -245,8 +245,7 @@ exports.getModule = class MrcModule extends ServerModule { | |||
| connectedSockets.forEach(client => { | |||
| if ( | |||
| message.to_user == '' || | |||
| // Fix PrivMSG delivery on case mismatch | |||
| message.to_user.toUpperCase() == client.username.toUpperCase() || | |||
| message.to_user == client.username.toUpperCase() || | |||
There was a problem hiding this comment.
These would technically be better using localeCompare with sensitivity 'accent'.
core/servers/chat/mrc_multiplexer.js
Outdated
| // Make sure to_user is always uppercase | ||
| try { | ||
| let to_user_uc = to_user.toUpperCase(); | ||
| to_user = to_user_uc; |
There was a problem hiding this comment.
This could just be to_user = to_user.toUpperCase(), no temp var. Or without the try:
to_user = (to_user || '').toUpperCase()
- Added msg delay on connect to space out commands - Fixed linewrap issue - Added MRC Trust verbs - Added PM local echo - Fixed to_user and from_user uppercase
|
Ok, I did a couple things in here to fix things I noticed while testing. |
|
@NuSkooler let me know if you have additional questions before merging the PR |
|
|
||
| const padding = ' |00' + ' '.repeat(padAmount); | ||
| chatLogView.addText(pipeToAnsi(msg + padding)); | ||
| chatLogView.addText(pipeToAnsi(msg)); |
There was a problem hiding this comment.
I'm not sure this will work correctly, I'll have to do some testing. This MR just got a bit bigger
There was a problem hiding this comment.
I have the latest client and it worked fine on my end. All the padding appeared to be from an older way of drawing the screen which appeared to have changed since it was first implemented (assumption here). On my end, it was working pretty well without it and fixed an issue with text wrapping on certain cases. Let me know if there is anything I missed.
Fixed previously added passthru (TRUST) Fixed trailing PIPE code sent to server unnecessarily
|
@NuSkooler |
| // room names are displayed with a # but referred to without. confusing. | ||
| room = room.replace(/^#/, ''); | ||
| this.state.room = room; | ||
| this.sendServerMessage(`NEWROOM:${this.state.room}:${room}`); | ||
|
|
||
| await this.msgDelay(100); |
Moved user_to uppercase to a different function
This fixes issue #551