Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fse err msg display tweak #511

Merged
merged 4 commits into from
Sep 29, 2023
Merged

fse err msg display tweak #511

merged 4 commits into from
Sep 29, 2023

Conversation

AnthonyHarwood
Copy link

Two changes, here.

  1. Clearing old error message text before setting new error message text. Currently the tail end of a previous error message remains when the length of the new text is shorter.
  2. When validating an empty email To field, return "Field cannot be empty" rather than the existing "Invalid username".

@NuSkooler
Copy link
Owner

FYI: Your PR is picking up unrelated changes from our other PRs. This one also has the bad change to the FTN parser.

Make sure you branch off of master then create your PR branches to avoid this.

NuSkooler
NuSkooler reviewed Sep 28, 2023
View reviewed changes
core/system_view_validate.js
@@ -91,7 +93,11 @@ function validateGeneralMailAddressedTo(data, cb) {
// :TODO: remove hard-coded FTN check here. We need a decent way to register global supported flavors with modules.
const addressedToInfo = getAddressedToInfo(data);

if (Message.AddressFlavor.FTN === addressedToInfo.flavor) {
if (addressedToInfo.name.length === 0) {
return cb(emptyFieldError());
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@AnthonyHarwood
Copy link
Author

FYI: Your PR is picking up unrelated changes from our other PRs. This one also has the bad change to the FTN parser.

Make sure you branch off of master then create your PR branches to avoid this.

Sorry about that. Now I realize how I made that mistake. I'll follow your advice, and try to be more careful.

@NuSkooler NuSkooler merged commit db8bd2f into NuSkooler:master Sep 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NuSkooler NuSkooler NuSkooler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnthonyHarwood @NuSkooler