Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3 Initial Skeleton Interface for Gate Driver #27

Merged
merged 3 commits into from
Feb 21, 2024
Merged

#3 Initial Skeleton Interface for Gate Driver #27

merged 3 commits into from
Feb 21, 2024

Conversation

nwdepatie
Copy link
Contributor

@nwdepatie nwdepatie commented Feb 18, 2024

Changes

Here is an initial skeleton for what I'm envisioning the interface for interacting with the gate driver to look like. A lot of this stuff is STM internal (i.e. the current ADCs) so we prob don't need "drivers" for that, but for the actual isolated ADC we probably do.

Notes

Moving forward, we are gonna have to be super anal about signal synchronization. Especially for PWM, we want to calculate all the PWM values to write and then write them all at once in an ideal world. I can take more of a look at how STM does this in our example code that was generated.

Test Cases

  • Made sure it built, since its a skeleton there isn't functionality yet

To Do

Lot of stuff outside of this PR to address in future tickets

  • double check STM interface for ADC callbacks (i.e. ADC -> DMA -> Interrupt -> STM HAL code probably -> Our callback)

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please reach out to your Project Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No merge conflicts
  • All checks passing
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #3

@nwdepatie nwdepatie self-assigned this Feb 18, 2024
@@ -35,44 +35,45 @@ BUILD_DIR = build
# source
######################################
# C sources
C_SOURCES = \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mind the changes in this file, I think that STM generated this with Windows line endings and I'm working on Linux so VSCode saved the whole file with Linux line endings


}

gatedriver_t* init_gatedriver()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The signature in the header has the identifier as init_gatedrv - mismatch here

@nwdepatie nwdepatie merged commit e2e93e6 into main Feb 21, 2024
1 check passed
@nwdepatie nwdepatie deleted the gate-drv branch February 21, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Interface] - Create Drive Interface
2 participants