Fixes #26065: OpenSCAP report needs to be rendered without iframe with sanitized html #779
+68
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
clarktsiory
force-pushed
the
bug_26065/openscap_report_needs_to_be_rendered_without_iframe_with_sanitized_html
branch
from
917530b to
6df43c9
Compare
|
Commit modified |
clarktsiory
force-pushed
the
bug_26065/openscap_report_needs_to_be_rendered_without_iframe_with_sanitized_html
branch
2 times, most recently
from
395f41a to
4c1fce2
Compare
|
Commit modified |
fanf
requested changes
Dec 13, 2024
...in/scala/com/normation/plugins/openscappolicies/extension/OpenScapNodeDetailsExtension.scala
Outdated
Show resolved
Hide resolved
|
Commit modified |
clarktsiory
force-pushed
the
bug_26065/openscap_report_needs_to_be_rendered_without_iframe_with_sanitized_html
branch
from
4c1fce2 to
a8e4ce8
Compare
|
PR updated with a new commit |
fanf
approved these changes
Dec 14, 2024
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
bug_26065/openscap_report_needs_to_be_rendered_without_iframe_with_sanitized_html
branch
from
63d8806 to
1d5d87e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/26065
We have to read the report file (as the API does) in the snippet, as pass the information down, to create buttons with a download action (similar to Normation/rudder#5941).
The iframe can be used to render the original report by putting the sanitized content as string in the srcdoc attribute
Result :
