Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25999: Disabling user rest API token feature from api-authorizations plugin UI #775

Open
wants to merge 1 commit into
base: branches/rudder/8.1
Choose a base branch
from

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Dec 3, 2024

https://issues.rudder.io/issues/25999

UI for the feature switch in Normation/rudder#6050 : essentially we don't display the user API token menu in the api-authorizations plugin snippet.
We still have an API endpoint to pass the configuration value, also there is some refactoring and formatting applied to the Elm code which knows about the status by calling the endpoint.

In the related PR, the user management roles and default providers are also changed, so there is some changes in the user-management plugin

@clarktsiory clarktsiory requested a review from fanf December 3, 2024 18:19
@clarktsiory clarktsiory marked this pull request as draft December 3, 2024 18:20
@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

@clarktsiory clarktsiory marked this pull request as ready for review December 3, 2024 18:43
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After further consideration, we wan to totally disable (not show) the pop-up when the feature is disabled (globally or for an user), as if the feature was not here.

@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

@clarktsiory
Copy link
Contributor Author

PR rebased

@clarktsiory clarktsiory force-pushed the bug_25999/disabling_user_rest_api_token_feature_from_api_authorizations_plugin_ui branch from d118a08 to 9d55a88 Compare December 12, 2024 16:06
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect !

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-plugins/pull/775
-- Your faithful QA
Kant merge: "In law a man is guilty when he violates the rights of others. In ethics he is guilty if he only thinks of doing so."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/94304/console)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants