Merge pull request #644 from VinceMacBuche/bug_24143/when_self_deploy…

…ment_is_enabled_you_can_still_deploy_your_changes

Fixes #24143: When self deployment is enabled, you can still deploy your changes.

change-validation/src/main/scala/com/normation/plugins/changevalidation/WorkflowService.scala

@@ -131,7 +131,7 @@ object TwoValidationStepsWorkflowServiceImpl {
   }
 
   private def canDeploy(isCreator: Boolean, selfDeployment: () => Box[Boolean]): Boolean = {
-    val correctActor = selfDeployment().getOrElse(false) || isCreator
+    val correctActor = selfDeployment().getOrElse(false) || !isCreator
     correctActor && CurrentUser.checkRights(AuthorizationType.Deployer.Edit)
   }