Skip to content

Commit

Permalink
Merge branch 'nessi.no-2023.06' of github.com:NorESSI/software-layer …
Browse files Browse the repository at this point in the history
…into nessi-2023.06-grpcio/1.57.0-GCCcore/12.3.0
  • Loading branch information
Richard Top committed Jun 18, 2024
2 parents 45a963b + 32c20ba commit fd25cdd
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 8 deletions.
2 changes: 1 addition & 1 deletion bot/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ else
fi
# Bind mount /sys/fs/cgroup so that we can determine the amount of memory available in our cgroup for
# Reframe configuration
TEST_STEP_ARGS+=("--extra-bind-paths" "/sys/fs/cgroup:/hostsys/fs/cgroup:ro")
# TEST_STEP_ARGS+=("--extra-bind-paths" "/sys/fs/cgroup:/hostsys/fs/cgroup:ro")

# prepare arguments to test_suite.sh (specific to test step)
declare -a TEST_SUITE_ARGS=()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ easyconfigs:
- cuDNN-8.9.2.26-CUDA-12.1.1.eb
- cuTENSOR-2.0.1.2-CUDA-12.1.1.eb
- Nextflow-23.10.0.eb
- EasyBuild-4.9.2.eb:
options:
from-pr: 20818
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,6 @@ easyconfigs:
- IPython-8.17.2-GCCcore-13.2.0.eb
- Qt5-5.15.13-GCCcore-13.2.0.eb
- NLTK-3.8.1-foss-2023b.eb
- Valgrind-3.23.0-gompi-2023b.eb:
options:
from-pr: 20792
10 changes: 5 additions & 5 deletions reframe_config_bot.py.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ site_configuration = {
'options': ['--mem={size}'],
}
],
'extras': {
# Make sure to round down, otherwise a job might ask for more mem than is available
# per node
'mem_per_node': __MEM_PER_NODE__,
},
# 'extras': {
# # Make sure to round down, otherwise a job might ask for more mem than is available
# # per node
# 'mem_per_node': __MEM_PER_NODE__,
# },
'max_jobs': 1
}
]
Expand Down
5 changes: 3 additions & 2 deletions test_suite.sh
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ if [[ "${cpuinfo}" =~ (Core\(s\) per socket:[^0-9]*([0-9]+)) ]]; then
else
fatal_error "Failed to get the number of cores per socket for the current test hardware with lscpu."
fi
cgroup_mem_bytes=$(cat /hostsys/fs/cgroup/memory/slurm/uid_${UID}/job_${SLURM_JOB_ID}/memory.limit_in_bytes)
# cgroup_mem_bytes=$(cat /hostsys/fs/cgroup/memory/slurm/uid_${UID}/job_${SLURM_JOB_ID}/memory.limit_in_bytes)
if [[ $? -eq 0 ]]; then
# Convert to MiB
cgroup_mem_mib=$((cgroup_mem_bytes/(1024*1024)))
Expand All @@ -177,7 +177,8 @@ sed -i "s/__NUM_CPUS__/${cpu_count}/g" $RFM_CONFIG_FILES
sed -i "s/__NUM_SOCKETS__/${socket_count}/g" $RFM_CONFIG_FILES
sed -i "s/__NUM_CPUS_PER_CORE__/${threads_per_core}/g" $RFM_CONFIG_FILES
sed -i "s/__NUM_CPUS_PER_SOCKET__/${cores_per_socket}/g" $RFM_CONFIG_FILES
sed -i "s/__MEM_PER_NODE__/${cgroup_mem_mib}/g" $RFM_CONFIG_FILES
# on local systems the change below is not the case, it works on AWS
# sed -i "s/__MEM_PER_NODE__/${cgroup_mem_mib}/g" $RFM_CONFIG_FILES

# Workaround for https://github.com/EESSI/software-layer/pull/467#issuecomment-1973341966
export PSM3_DEVICES='self,shm' # this is enough, since we only run single node for now
Expand Down

0 comments on commit fd25cdd

Please sign in to comment.