chore: require readonly properties to be immutable #6006
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This draft showcases an example implementation of #6005.
It enforces readonly props immutability via an ESLint plugin - https://github.com/galargh/eslint-plugin-immutable-readonly
It needs further discussion whether that's something that we want to enforce automatically.
It also needs further work as, currently, the plugin is only published to the GitHub packages (downloading from GitHub packages requires authentication with a GitHub token).