Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: require readonly properties to be immutable #6006

Closed
wants to merge 3 commits into from

Conversation

galargh
Copy link
Member

@galargh galargh commented Nov 28, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

This draft showcases an example implementation of #6005.

It enforces readonly props immutability via an ESLint plugin - https://github.com/galargh/eslint-plugin-immutable-readonly

It needs further discussion whether that's something that we want to enforce automatically.

It also needs further work as, currently, the plugin is only published to the GitHub packages (downloading from GitHub packages requires authentication with a GitHub token).

Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 5:43pm

Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: 2db19dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Nov 28, 2024
@galargh
Copy link
Member Author

galargh commented Nov 28, 2024

I'm going to close this draft for now, I just wanted to be able to link to an example implementation from the issue that captures this work item - #6005

@galargh galargh closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant