Merge pull request #5971 from NomicFoundation/readonly-network-config

chore: prevent network configuration properties from being modified
NomicFoundation · Nov 30, 2024 · 8becb03 · 8becb03
2 parents fd3b0cc + 484f1ca
commit 8becb03
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/v-next/hardhat-ethers/src/internal/hardhat-ethers-provider/hardhat-ethers-provider.ts b/v-next/hardhat-ethers/src/internal/hardhat-ethers-provider/hardhat-ethers-provider.ts
@@ -85,7 +85,7 @@ export class HardhatEthersProvider implements HardhatEthersProviderI {
 
   readonly #hardhatProvider: EthereumProvider;
   readonly #networkName: string;
-  readonly #networkConfig: NetworkConfig;
+  readonly #networkConfig: Readonly<NetworkConfig>;
 
   // event-emitter related fields
   #latestBlockNumberPolled: number | undefined;

diff --git a/v-next/hardhat-ethers/src/internal/hardhat-helpers/hardhat-helpers.ts b/v-next/hardhat-ethers/src/internal/hardhat-helpers/hardhat-helpers.ts
@@ -27,7 +27,7 @@ interface Link {
 export class HardhatHelpers {
   readonly #provider: HardhatEthersProvider;
   readonly #networkName: string;
-  readonly #networkConfig: NetworkConfig;
+  readonly #networkConfig: Readonly<NetworkConfig>;
   readonly #artifactManager: ArtifactsManager;
 
   constructor(

diff --git a/...l/builtin-plugins/network-manager/json-rpc-request-modifiers/json-rpc-request-modifier.ts b/...l/builtin-plugins/network-manager/json-rpc-request-modifiers/json-rpc-request-modifier.ts
@@ -35,7 +35,7 @@ import { isHttpNetworkConfig } from "./utils.js";
  */
 export class JsonRpcRequestModifier {
   readonly #provider: EthereumProvider;
-  readonly #networkConfig: NetworkConfig;
+  readonly #networkConfig: Readonly<NetworkConfig>;
 
   // accounts
   #localAccounts: LocalAccounts | undefined;

diff --git a/v-next/hardhat/src/internal/builtin-plugins/network-manager/network-connection.ts b/v-next/hardhat/src/internal/builtin-plugins/network-manager/network-connection.ts
@@ -12,7 +12,7 @@ export class NetworkConnectionImplementation<
 {
   public readonly id: number;
   public readonly networkName: string;
-  public readonly networkConfig: NetworkConfig;
+  public readonly networkConfig: Readonly<NetworkConfig>;
   public readonly chainType: ChainTypeT;
 
   #provider!: EthereumProvider;

diff --git a/v-next/hardhat/src/internal/builtin-plugins/network-manager/network-manager.ts b/v-next/hardhat/src/internal/builtin-plugins/network-manager/network-manager.ts
@@ -20,7 +20,7 @@ import { isNetworkConfig, validateNetworkConfig } from "./type-validation.js";
 export class NetworkManagerImplementation {
   readonly #defaultNetwork: string;
   readonly #defaultChainType: DefaultChainType;
-  readonly #networkConfigs: Record<string, NetworkConfig>;
+  readonly #networkConfigs: Readonly<Record<string, Readonly<NetworkConfig>>>;
   readonly #hookManager: HookManager;
 
   #nextConnectionId = 0;

diff --git a/v-next/hardhat/src/types/network.ts b/v-next/hardhat/src/types/network.ts
@@ -53,7 +53,7 @@ export interface NetworkConnection<
 > {
   readonly id: number;
   readonly networkName: string;
-  readonly networkConfig: NetworkConfig;
+  readonly networkConfig: Readonly<NetworkConfig>;
   readonly chainType: ChainTypeT;
   readonly provider: EthereumProvider;