fix: do not call process.exit; set process.exitCode instead

NomicFoundation · Jul 31, 2024 · 570f79d · 570f79d
1 parent 9cae5e7
commit 570f79d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/packages/hardhat-solhint/src/index.ts b/packages/hardhat-solhint/src/index.ts
@@ -136,6 +136,7 @@ task("check", async (_, { run }, runSuper) => {
   );
 
   if (errorsCount > 0) {
-    process.exit(1);
+    process.exitCode = 1;
+    return;
   }
 });
diff --git a/packages/hardhat-solhint/test/tests.ts b/packages/hardhat-solhint/test/tests.ts
@@ -36,28 +36,24 @@ describe("Solhint plugin", function () {
       );
     });
 
-    it("should run the check task and exit", async function () {
+    it("should run the check task and set the exit code to 1", async function () {
       const consoleLogStub = sinon.stub(console, "log");
-      const processExitStub = sinon.stub(process, "exit");
       await this.env.run("check");
       assert.isTrue(consoleLogStub.calledOnce);
-      assert.isTrue(processExitStub.calledOnceWith(1));
+      assert.strictEqual(process.exitCode, 1);
       consoleLogStub.restore();
-      processExitStub.restore();
+      process.exitCode = undefined;
     });
   });
 
   describe("Project with no errors", function () {
     useEnvironment("no-errors-project");
 
-    it("should run the check task and not exit", async function () {
+    it("should run the check task and not set the exit code", async function () {
       const consoleLogStub = sinon.stub(console, "log");
-      const processExitStub = sinon.stub(process, "exit");
       await this.env.run("check");
       assert.isTrue(consoleLogStub.calledOnce);
-      assert.isTrue(processExitStub.notCalled);
-      consoleLogStub.restore();
-      processExitStub.restore();
+      assert.strictEqual(process.exitCode, undefined);
     });
   });