Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Codecove to v4 #364

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Upgrade Codecove to v4 #364

merged 1 commit into from
Aug 6, 2024

Conversation

Lilferrit
Copy link
Contributor

Upgrade the Codecov version used in GitHub actions in order to resolve #363.

@Lilferrit Lilferrit linked an issue Aug 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (f792527) to head (a3c4496).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   89.23%   89.77%   +0.53%     
==========================================
  Files          12       12              
  Lines         929      929              
==========================================
+ Hits          829      834       +5     
+ Misses        100       95       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lilferrit Lilferrit requested a review from bittremieux August 5, 2024 23:45
@bittremieux bittremieux merged commit bf1e5a3 into main Aug 6, 2024
6 checks passed
@bittremieux bittremieux deleted the codecov-fix branch August 6, 2024 07:11
Lilferrit added a commit that referenced this pull request Aug 21, 2024
* prediction output in model eval mode

* eliminate eval command, introduce -e flag for predict command

* adapted unit test to new model runner and model functionality

* updated documentation

* removed log and result files

* Generate new screengrabs with rich-codex

* Update paper reference (#361)

* Bug report template (#360)

* bug report template

* punctuation, hardware description item

* Restrict NumPy to pre-2.0 (#344)

* Restrict NumPy to pre-2.0

* Update changelog

* Update paper reference (#361)

---------

Co-authored-by: Lilferrit <[email protected]>

* upgrade codecove to v4 (#364)

* implemen eval mode at model runner level, fix unit test

* CLI documentation

* Generate new screengrabs with rich-codex

* requested changes

* Generate new screengrabs with rich-codex

* evaluation test cases

* file warnings, evaluation tests

* fixed ubuntu specific test case bug

* verify annotated mgf files

* verify annotated mgf files

* Generate new screengrabs with rich-codex

* Save best model (#365)

* save best model

* save best model

* updated unit tests

* remove save top k config item

* added save_top_k to deprecated config options

* changelog entry

* test case, formatting

* requested changes

* prediction output in model eval mode

* eliminate eval command, introduce -e flag for predict command

* adapted unit test to new model runner and model functionality

* updated documentation

* removed log and result files

* implemen eval mode at model runner level, fix unit test

* CLI documentation

* Bug report template (#360)

* bug report template

* punctuation, hardware description item

* Restrict NumPy to pre-2.0 (#344)

* Restrict NumPy to pre-2.0

* Update changelog

* Update paper reference (#361)

---------

Co-authored-by: Lilferrit <[email protected]>

* requested changes

* evaluation test cases

* file warnings, evaluation tests

* fixed ubuntu specific test case bug

* verify annotated mgf files

* AnnotatedSpectrumIndex type error

* requested changes, changelog entry

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Wout Bittremieux <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codecov Github Actions job fails in MacOS container.
2 participants