Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

313 save final model #340

Merged
merged 11 commits into from
Jun 28, 2024
Merged

313 save final model #340

Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2745865
implemented save last checkpoint
Lilferrit Jun 20, 2024
c58b661
implemented last checkpoint saving using trainer save_checkpoint inst…
Lilferrit Jun 20, 2024
3f033b2
final checkpoint file name
Lilferrit Jun 20, 2024
8e292b1
added final epoch number to final checkpoint name
Lilferrit Jun 20, 2024
b57ea7d
linter rules
Lilferrit Jun 20, 2024
a034f1f
save final model using ModelCheckpoint callback
Lilferrit Jun 25, 2024
5c4ba09
implemented save model unit test
Lilferrit Jun 26, 2024
3ee349b
fixed test_runner save checkpoints to working directory bug
Lilferrit Jun 26, 2024
7db5c04
save final model test refactor
Lilferrit Jun 28, 2024
0247534
Merge branch 'dev' into 313-save-final-model
Lilferrit Jun 28, 2024
a743dc5
save final model changelog entry
Lilferrit Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions casanovo/denovo/model_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,22 @@ def __init__(
self.writer = None

# Configure checkpoints.
self.callbacks = [
ModelCheckpoint(
dirpath=config.model_save_folder_path,
save_on_train_epoch_end=True,
)
]

if config.save_top_k is not None:
self.callbacks = [
self.callbacks.append(
ModelCheckpoint(
dirpath=config.model_save_folder_path,
monitor="valid_CELoss",
mode="min",
save_top_k=config.save_top_k,
)
]
else:
self.callbacks = None
)

def __enter__(self):
"""Enter the context manager"""
Expand Down
Loading