Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests on macOS with M1 support #301

Closed
wants to merge 3 commits into from
Closed

Conversation

bittremieux
Copy link
Collaborator

See here for the available (free) runners for GitHub Actions.

@bittremieux bittremieux requested a review from wfondrie February 20, 2024 19:01
@bittremieux
Copy link
Collaborator Author

It does seem like we're immediately running into MPS-related errors. @wfondrie is this something you can easily diagnose?

@bittremieux
Copy link
Collaborator Author

I tried to set PYTPYTORCH_MPS_HIGH_WATERMARK_RATIO=0.0, as suggested by the error message, but that didn't solve the issue. There are (conflicting) reports here that this issue might get solved in PyTorch 2.3, which is scheduled for release in April.

As a non-macOS user and lacking familiarity with this error, I currently don't see many other options than to wait until then.

@bittremieux
Copy link
Collaborator Author

Apparently MPS is not actually available for the GitHub Action runners, so there's no way to test this currently. #327 has disabled running on M1/M2 chips (which will automatically try to use MPS), so at least our tests don't fail anymore.

@bittremieux bittremieux deleted the test_macos_m1 branch May 15, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant