Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure --model has to be set when not training from scratch #286

Closed
wants to merge 3 commits into from
Closed

Ensure --model has to be set when not training from scratch #286

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6204d37
added check
gdewael Jan 30, 2024
f5de117
black format
gdewael Jan 30, 2024
d8954b3
reconfigure to default config
gdewael Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions casanovo/denovo/model_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,19 @@ def initialize_model(self, train: bool) -> None:
self.config.train_from_scratch,
self.model_filename is None,
)

if (
train
and (not self.config.train_from_scratch)
and (self.model_filename is None)
):
logger.error(
"Training with `train_from_scratch: False` requires an input `--model`."
)
raise ValueError(
"Training with `train_from_scratch: False` requires an input `--model`."
)

if train and any(from_scratch):
self.model = Spec2Pep(**model_params)
return
Expand Down