-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update output
command-line description
#276
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #276 +/- ##
=======================================
Coverage 89.54% 89.54%
=======================================
Files 12 12
Lines 918 918
=======================================
Hits 822 822
Misses 96 96 ☔ View full report in Codecov by Sentry. |
How does Casanovo handle model file naming when fine-tuning a model? In this case, it seems like --model will be used to specify the name of the input file AND the output file. Problem! Do we need separate --model-in and --model-out options? Alternatively, is there some scheme whereby we name the trained model with the epoch number in the filename? If so, this should be documented here. |
By default, checkpoint files are named in the |
OK, so this is obviously bad, because if I train two models from the same working directory, the files will overwrite one another. We should change this to be |
I just ran into another problem which needs to be fixed, probably on this PR. It seems like Casanovo is trying to do something smart if I specify an As we discussed, we should add an The argument to |
Superseded by #372. |
Fixes #241.