Correctly report AA precision and recall during validation #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #253 +/- ##
=======================================
Coverage 89.24% 89.24%
=======================================
Files 12 12
Lines 902 902
=======================================
Hits 805 805
Misses 97 97
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
melihyilmaz
added a commit
that referenced
this pull request
Nov 2, 2023
* Remove unused custom_encoder option (#254) * resolves issue #238: remove custom_encoder option * fixed lint issue * fixed lint issue * Revert "fixed lint issue" This reverts commit bd1366c. * lint * lint issue * Consistently format changelog. --------- Co-authored-by: Isha Gokhale <[email protected]> Co-authored-by: Wout Bittremieux <[email protected]> * Correctly report AA precision and recall during validation (#253) Fixes #252. Co-authored-by: Melih Yilmaz <[email protected]> * Remove gradient calculation during inference (#258) * Remove force_grad in inference * Upgrade required PyTorch version * Update CHANGELOG.md * Update CHANGELOG.md * Fix typo in torch version * Specify correct Pytorch version change --------- Co-authored-by: Wout Bittremieux <[email protected]> * Add label smoothing * Modify config file * Minor fix config.yaml * Run black * Lint casanovo.py --------- Co-authored-by: ishagokhale <[email protected]> Co-authored-by: Isha Gokhale <[email protected]> Co-authored-by: Wout Bittremieux <[email protected]> Co-authored-by: Wout Bittremieux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252.
AA precision and recall were swapped due to swapped input of true and predicted peptides to the evaluation.