update project standards #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaronsaray this is ready for review. I swapped out the Docker mysql image like we discussed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in a bunch of changes we've made over the last year or so since we originally created this project standard.
The most notable changes:
This might be a good one to review commit by commit since all the coding standard tweaks are in a single commit.
I'm having second thoughts on using the Oracle
mysql/mysql-serverDocker images. They seem really stale (over a year old, and stuck on 8.0.32). Meanwhile, the Docker-provided mysql images are fully up to date, even has 8.2.0 pre-release stuff, and supports arm architecture now. Should we flip it back?