Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word wrap bug #279

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Word wrap bug #279

merged 2 commits into from
Feb 27, 2023

Conversation

newdydx
Copy link
Contributor

@newdydx newdydx commented Feb 19, 2023

Closes #

What new changes did you make? Tick all applicable boxes

  • Added new abbreviation
  • Fixed something in the source code
  • Added a new feature
  • Fixed the docs (README.md, CONTRIBTUING.md, etc)

Describe the new changes you added.

I fixed a bug on #88

Share a screenshot of new changes

@vercel
Copy link

vercel bot commented Feb 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
abbreve ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 19, 2023 at 9:13PM (UTC)

@Njong392
Copy link
Owner

Njong392 commented Feb 27, 2023

Thank you so much for the changes! You fixed an issue that has been here for a long time. But there is a tiny thing I think would be a great addition to your PR. That's if you are interested in fixing it.

As you can see below, the section above and the one below are not aligned. To me, this doesn't really look okay. Maybe we could create a gap so that the section above and the one below are aligned and the extra margin from the section above goes away.

What do you think? Will you go for it, or should I merge this pull request and create another issue?

pr

@newdydx
Copy link
Contributor Author

newdydx commented Feb 27, 2023

@Njong392 I think you should merge this pull request and I will create another issue concerning that and work on it and if you want to create the issue too I will be glad to work on the issue. Thanks

@Njong392 Njong392 merged commit 0c3440c into Njong392:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants