Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put a word-wrap property for the => | errorMessage & isUserInputBlank | text which appear when either of both States are true. #88

Open
PriyansuMaurya opened this issue Oct 6, 2022 · 33 comments
Labels
bug Something isn't working

Comments

@PriyansuMaurya
Copy link
Contributor

Description

When we put wrong slang or slang that is not present or the search bar is empty, we get a msg telling us the real problem like
this

1. When slag is not present

- This entry does not exist in our records as of yet :(

  1. You can help us add this by creating a [github issue](https://github.com/Njong392/Abbreve)

  2. Or, you could fill out this [feedback form](https://t.co/mp86BLYBhq) and we will address the issue

2. When SearchBar is Empty

- Search bar 🔍 is Empty!. Please put abbreviation in search bar    

But when either of these messages appears, the content on its left gets displaced slightly to the left. it will more clear from the SS I have added below.

Screenshots

Screenshot (6)

Screenshot (7)

Screenshot (9)

Additional information

No response

@PriyansuMaurya PriyansuMaurya added the bug Something isn't working label Oct 6, 2022
@adropofilm
Copy link
Collaborator

Sounds great, @PriyansuMaurya do you want me to assign this to you?

@PriyansuMaurya
Copy link
Contributor Author

No, I didn't put it to get this assigned to me, bcoz I don't know much about tailwind. it's for the general public, if it doesn't get solved this month, then definitely I will learn tailwind and try to solve it in the next month.

@Njong392
Copy link
Owner

Njong392 commented Oct 6, 2022

No, I didn't put it to get this assigned to me, bcoz I don't know much about tailwind. it's for the general public, if it doesn't get solved this month, then definitely I will learn tailwind and try to solve it in the next month.

Thank you for raising this Priyansu! If no one takes this on, I'll try to go over it and see what I can do 💙

@ctoffanin ctoffanin mentioned this issue Oct 15, 2022
@adropofilm
Copy link
Collaborator

adropofilm commented Oct 15, 2022

I can try to tackle this if that's cool with you @Njong392 ?

@adropofilm adropofilm assigned adropofilm and unassigned adropofilm Oct 15, 2022
@Njong392
Copy link
Owner

@adropofilm are you still on this?

@adropofilm adropofilm removed their assignment Nov 5, 2022
@adropofilm
Copy link
Collaborator

Hi friends, passing this on to anyone who wants to take it up. Been assigned to me for a while, sorry!

@Njong392
Copy link
Owner

Njong392 commented Nov 7, 2022

I think it's safe to close this. Since we moved the search bar to the top, we don't have much of this problem anymore. What do you think @adropofilm

@PriyansuMaurya
Copy link
Contributor Author

PriyansuMaurya commented Nov 7, 2022

The bug has not been fixed till now although the search bar has been moved to the top. You can see this in the video 👇
Abbreve_Trim (2)

@Njong392
Copy link
Owner

Ooof... I somehow missed this issue. Thanks for the video @PriyansuMaurya I'll set out to fix some stuff this weekend.

@TropicolX
Copy link

Hi. Can I be assigned to this issue? I have experience with tailwind CSS.

@Njong392
Copy link
Owner

Hi there! Yes, sure. I'll assign you.

@TropicolX
Copy link

@Njong392 I've made a PR for the issue

@Njong392
Copy link
Owner

I saw. Thank you. I think replied to the pull request and suggested some changes.

@newdydx
Copy link
Contributor

newdydx commented Feb 12, 2023

@Njong392 I checked and this issue has not been resolved.....Can i be given the permission to work on this so we could close this issue.

@Njong392
Copy link
Owner

@newdydx i think the issue that the site has now is that the text near the search bar doesn't align with the content below it. It's shifted inward. And then continuously shifts outward as described by this issue.

Should I assign you still?

@newdydx
Copy link
Contributor

newdydx commented Feb 13, 2023

@Njong392 of course you can assign me...After going through the site I discovered the second issue had been resolved and the only issue left is the issue of the word wrap and I would love to work on the issue.....thanks

@Njong392
Copy link
Owner

Assigning you. Thank you for taking it on.

@Njong392
Copy link
Owner

Oh wait. This issue is assigned to @TropicolX Would you still be interested in working on this?

@newdydx
Copy link
Contributor

newdydx commented Feb 15, 2023

@Njong392 still waiting to be assigned

@Njong392
Copy link
Owner

If by the weekend, the originally assigned person doesn't respond, I'll assign you then. All good?

@newdydx
Copy link
Contributor

newdydx commented Feb 16, 2023

@Njong392 no problem

@Njong392
Copy link
Owner

@newdydx assigning you to this now.

@Njong392 Njong392 assigned newdydx and unassigned TropicolX Feb 18, 2023
@newdydx newdydx mentioned this issue Feb 19, 2023
4 tasks
@newdydx
Copy link
Contributor

newdydx commented Feb 19, 2023

@Njong392 I made the pull request

@devodii
Copy link

devodii commented Apr 22, 2023

Has it been resolved?

@Njong392
Copy link
Owner

Has it been resolved?

Ah yes. This was fixed. However, the content on the page does not quite align and does not really look okay. Some sections are closer to the edges than others. Would you like to be assigned @devodii ?

@devodii
Copy link

devodii commented Apr 24, 2023

Yes...
Also, I've added a fancy scrollbar that matches the color. Supposed to be merged but you haven't.
May I know why?

@Njong392
Copy link
Owner

@devodii I already reviewed your pull request. Please check the comments I made.

@Njong392 Njong392 assigned devodii and unassigned newdydx Apr 24, 2023
@devodii
Copy link

devodii commented Apr 25, 2023

The caret in the search field seems to be hiding when it's focused but shows after the field is not null.
Should i work on this?

scrnli_4_25_2023_1-44-59.PM.mp4

@Njong392
Copy link
Owner

This looks like an issue totally different from this one.It should be created separately. And I assigned you to this issue already btw

@devodii
Copy link

devodii commented Apr 25, 2023

Oh...
The one you assigned to me, i don't understand it.
I guess it's the fact that the notFound message moves to the left when it has no record for the value inputed.
Correct?

@PriyansuMaurya
Copy link
Contributor Author

PriyansuMaurya commented Jun 1, 2023

This is what we want, don't we? @Njong392

Before
image

After Filling and Clicking SUBSCRIBE button

image

Here nothing moves (stays as it was except message appears)

Here is the code for the same

image

For more clarity visit https://priyansu.vercel.app/
And Repo https://github.com/PriyansuMaurya/portfolio

@Njong392
Copy link
Owner

Njong392 commented Jun 2, 2023

Ah, it took me a minute to see what u meant. But yeah. That is the expected reaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@adropofilm @TropicolX @Njong392 @PriyansuMaurya @newdydx @devodii and others