Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: rename unofficial package into proglodyte-wasm #44962

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Aug 13, 2018

Motivation for this change

The package is a concurrent to the official wasm interpreter (available as ocamlPackages.wasm), so I think the name is treacherous :)

If this could get in before 18.09 branch-off it'd likely be best, as it's a breaking change.

cc @proglodyte

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Aug 13, 2018
@matthewbauer
Copy link
Member

This will probably need an alias.

@Ekleog
Copy link
Member Author

Ekleog commented Aug 16, 2018

Hmmm, so alias for 18.09, and after branch-off remove the alias? (the idea, at least for me, is to avoid tricking people into thinking that's a kind of “official” wasm interpreter, as that was what I thought until I came upon ocamlPackages.wasm -- next step would have been to setup an alias from wasm to ocamlPackages.wasm, which is the official one)

Anyway, the following plan would likely make for less disruption than my initial idea of just removing the wasm package straightaway, at the cost of one more release before the wasm package finds its correct target:

  • Alias wasm to proglodyte-wasm
  • After 18.09 branch-off, remove the wasm alias
  • After 19.03 branch-off, add a wasm alias to ocamlPackages.wasm

Does that sound good to you?

@Ekleog
Copy link
Member Author

Ekleog commented Oct 14, 2018

@matthewbauer Up. Does that sound good to you? (we already missed the 18.09 branch-off)

  • Alias wasm to proglodyte-wasm
  • After 19.03 branch-off, remove the wasm alias
  • After 19.09 branch-off, add a wasm alias to ocamlPackages.wasm

@matthewbauer
Copy link
Member

Yeah sounds ok.

@matthewbauer matthewbauer merged commit 1dae462 into NixOS:master Oct 14, 2018
@Ekleog
Copy link
Member Author

Ekleog commented Oct 15, 2018

@matthewbauer Erhm… the PR wasn't actually adding the alias yet, as I was unsure this was OK with you :'( I've opened #48444 to add the alias back, think it'd be great if this could get merged ASAP to avoid in-between hydra bumps. (either that or live with the absence of alias, but that was the original issue :/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants