Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

teams: create Android team #368434

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Conversation

numinit
Copy link
Contributor

@numinit numinit commented Dec 26, 2024

We have needed this for a while, especially as it relates to coordinating Android repo updates.

Create it with the people who expressed interest in: #359918

CC: @hadilq @adrian-gierakowski @RossComputerGuy @tadfisher

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/creating-the-android-team/57914/1

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 26, 2024
@numinit
Copy link
Contributor Author

numinit commented Dec 27, 2024

I think there's some process for making a GH org so we can get pinged. I'll look into it.

@RossComputerGuy
Copy link
Member

I can make the team but there's someone else with org perms who'll need to enable stuff.

@numinit
Copy link
Contributor Author

numinit commented Dec 27, 2024

Thanks Tristan!

@RossComputerGuy
Copy link
Member

https://github.com/orgs/NixOS/teams/android been created

@RossComputerGuy
Copy link
Member

Are there any plans to make the Android team a codeowner of things? If so, we'll need someone to come in and change stuff.

@numinit
Copy link
Contributor Author

numinit commented Dec 27, 2024

Updated to add @NixOS/android to teams.nix, and reflect who's in it.

@numinit
Copy link
Contributor Author

numinit commented Dec 27, 2024

@RossComputerGuy At some point, probably. I don't think we need to do so preemptively until we get an automated update/test pipeline going for androidenv packages.

@RossComputerGuy
Copy link
Member

Cool, then everything is good to go.

We have needed this for a while, especially as it relates to
coordinating Android repo updates.

Create it with the people who expressed interest in:
NixOS#359918
Copy link
Member

@RossComputerGuy RossComputerGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image0

@RossComputerGuy
Copy link
Member

Anything else or good to merge?

@numinit
Copy link
Contributor Author

numinit commented Dec 28, 2024

Should be good. If anyone else wants to be added, we'll do that in subsequent PRs.

@RossComputerGuy RossComputerGuy merged commit a35b4a5 into NixOS:master Dec 28, 2024
23 of 24 checks passed
khaneliman pushed a commit to khaneliman/nixpkgs that referenced this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants