-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
teams: create Android team #368434
teams: create Android team #368434
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/creating-the-android-team/57914/1 |
I think there's some process for making a GH org so we can get pinged. I'll look into it. |
I can make the team but there's someone else with org perms who'll need to enable stuff. |
Thanks Tristan! |
https://github.com/orgs/NixOS/teams/android been created |
1a34fa3
to
b154fec
Compare
Are there any plans to make the Android team a codeowner of things? If so, we'll need someone to come in and change stuff. |
Updated to add @NixOS/android to teams.nix, and reflect who's in it. |
@RossComputerGuy At some point, probably. I don't think we need to do so preemptively until we get an automated update/test pipeline going for androidenv packages. |
Cool, then everything is good to go. |
We have needed this for a while, especially as it relates to coordinating Android repo updates. Create it with the people who expressed interest in: NixOS#359918
b154fec
to
4cdcd2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything else or good to merge? |
Should be good. If anyone else wants to be added, we'll do that in subsequent PRs. |
We have needed this for a while, especially as it relates to coordinating Android repo updates.
Create it with the people who expressed interest in: #359918
CC: @hadilq @adrian-gierakowski @RossComputerGuy @tadfisher
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.