electronplayer: drop #365924
Merged
electronplayer: drop #365924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluiedev
force-pushed
the
push-lluuuyoqmpyl
branch
from
da748d6 to
8380005
Compare
github-actions
bot
added
10.rebuild-darwin: 0
donovanglover
approved these changes
Dec 27, 2024
ElectronPlayer had been unmaintained and its repository archived since October 28, 2024. It evidently had already been struggling to function for years, judging by [the section titled "The Pain of Widevine"](https://github.com/oscartbeaumont/ElectronPlayer/blob/master/README.md#the-pain-of-widevine) in its README file, and the last commit dates from October 9, 2021, over three years before the repository was archived. All in all, it is a dead project that had been broken for years, and we shouldn't continue to support it in 25.05.
pluiedev
force-pushed
the
push-lluuuyoqmpyl
branch
from
8380005 to
411a5e2
Compare
donovanglover
approved these changes
Dec 27, 2024
donovanglover
added
the
12.approvals: 1
fpletz
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ElectronPlayer had been unmaintained and its repository archived since October 28, 2024.
It evidently had already been struggling to function for years, judging by the section titled "The Pain of Widevine" in its README file, and the last commit dates from October 9, 2021, over three years before the repository was archived.
All in all, it is a dead project that had been broken for years, and we shouldn't continue to support it in 25.05.
Part of #296939
Pinging maintainer @ImExtends
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.