Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbcl: fix check phase for darwin 24.05 only #361072

Open
wants to merge 1 commit into
base: staging-24.05
Choose a base branch
from

Conversation

hraban
Copy link
Member

@hraban hraban commented Dec 2, 2024

Things done

See #359214 and in particular @szlend’s comment. Thanks to @pcboy for reporting.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

See NixOS#359214 and in particular @szlend’s
comment.  Thanks to @pcboy for reporting.
@hraban hraban marked this pull request as ready for review December 2, 2024 13:14
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 2, 2024
@ofborg ofborg bot requested review from lukego, 7c6f434c, Uthar and nagy December 3, 2024 00:55
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 3, 2024
Copy link
Member

@szlend szlend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to go through staging-24.05 if it's only rebuilding 11-100 packages? Otherwise it looks good to me.

@hraban
Copy link
Member Author

hraban commented Dec 3, 2024

no it's fine to include somewhere directly I just don't know what the proper target branch is. What's the 24.05 equivalent of master?

Although I am surprised at the low rebuild count... maybe because it fixes a previously broken package? On master, changing sbcl causes an avalanche of >1k lisp package rebuilds.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants