-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
curl: add hyper support #357552
curl: add hyper support #357552
Conversation
This should target staging. |
66f3991
to
8193910
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it's actually false
, we are not shipping curl with hyper, unlike what the post wants.
I would let the issue stay open and change the issue title to "curl: move to the hyper backend".
I think it's great to add the support by default, once it is stable, that is.
# | ||
# Make sure rustc always emits cdylib artifacts | ||
postPatch = '' | ||
ln -sf ${./Cargo.lock} Cargo.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream does not commit their lockfiles?
I think a better approach would be to ask upstream to commit their lockfile, mentioning our reproducibility requirements which needs the lockfile to compare the hash with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hyper is usually used as a library, and Cargo's commit guidelines generally advise against including a Cargo.lock for libraries
Apparently that's a historical practice: https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control leaves the choice open while stating that Cargo.lock doesn't affect library consumers. I guess it's okay to ask them to add a Cargo.lock then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened hyperium/hyper#3788
8193910
to
8bee890
Compare
Curl has officially removed hyper support: https://daniel.haxx.se/blog/2024/12/21/dropping-hyper/
|
Closes #357409Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.