Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-analyzer-unwrapped: 2024-09-02 -> 2024-11-11 #354304

Merged
merged 9 commits into from
Nov 17, 2024
Merged

rust-analyzer-unwrapped: 2024-09-02 -> 2024-11-11 #354304

merged 9 commits into from
Nov 17, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Nov 7, 2024 •
edited
Loading

Things done

https://github.com/rust-lang/rust-analyzer/releases/tag/2024-11-04
https://github.com/rust-lang/rust-analyzer/releases/tag/2024-11-11

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@khaneliman khaneliman changed the title rust-analyzer-unwrapped: 2024-09-02 -> 20-24-11-04 rust-analyzer-unwrapped: 2024-09-02 -> 2024-11-04 Nov 7, 2024
@ofborg ofborg bot requested a review from oxalica November 7, 2024 22:42
@khaneliman khaneliman marked this pull request as draft November 9, 2024 21:04
@khaneliman
Copy link
Contributor Author

Need to look into the neovim test failure.

@oxalica
Copy link
Contributor

oxalica commented Nov 10, 2024

The r-a binary works for my nvim/coc.nvim setup, and I couldn't reproduce the failure by running the test script with nix develop --ignore-environment env. I guess it might be some other env issue which prevents r-a from finding the std src.

Could we disable that test for now?

@khaneliman khaneliman marked this pull request as ready for review November 16, 2024 05:35
@khaneliman
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354304

x86_64-linux

✅ 4 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vscode-extensions.rust-lang.rust-analyzer

aarch64-linux

✅ 4 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vscode-extensions.rust-lang.rust-analyzer

x86_64-darwin

✅ 4 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vscode-extensions.rust-lang.rust-analyzer

aarch64-darwin

✅ 4 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vscode-extensions.rust-lang.rust-analyzer

@khaneliman
Copy link
Contributor Author

The r-a binary works for my nvim/coc.nvim setup, and I couldn't reproduce the failure by running the test script with nix develop --ignore-environment env. I guess it might be some other env issue which prevents r-a from finding the std src.

Could we disable that test for now?

Yeah, looks like something recently affected the test environment. I can recreate the test failing on master, too. I'm just disabling it, for now.

@oxalica oxalica mentioned this pull request Nov 16, 2024
Closed
@khaneliman
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354304

x86_64-linux

✅ 4 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vscode-extensions.rust-lang.rust-analyzer

aarch64-linux

✅ 4 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vscode-extensions.rust-lang.rust-analyzer

x86_64-darwin

✅ 4 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vscode-extensions.rust-lang.rust-analyzer

aarch64-darwin

✅ 4 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vscode-extensions.rust-lang.rust-analyzer

oxalica
oxalica approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@oxalica oxalica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Tested to work with neovim/coc.nvim.

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 354304

x86_64-linux

✅ 4 packages built:
  • ra-multiplex
  • rust-analyzer
  • rust-analyzer-unwrapped
  • vscode-extensions.rust-lang.rust-analyzer

@khaneliman khaneliman changed the title rust-analyzer-unwrapped: 2024-09-02 -> 2024-11-04 rust-analyzer-unwrapped: 2024-09-02 -> 2024-11-11 Nov 17, 2024
@ofborg ofborg bot requested a review from oxalica November 17, 2024 12:16
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Nov 17, 2024
@khaneliman khaneliman merged commit 7f36c78 into NixOS:master Nov 17, 2024
39 of 40 checks passed
@khaneliman khaneliman deleted the rust-analyzer branch November 17, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxalica oxalica Awaiting requested review from oxalica

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khaneliman @oxalica @wegank